LucasandClaude Fable 5
d6b5ce99de
* fix(relay): set Request.GetBody so the HTTP/2 transport can transparently retry after an upstream stream reset
The outbound request body is a type-erased io.Reader over BodyStorage, so
net/http cannot derive Request.GetBody (it only does so for *bytes.Reader,
*bytes.Buffer and *strings.Reader). With GetBody nil, the HTTP/2 transport
cannot transparently retry a request once the body has been written and the
upstream resets the stream with a retryable error (REFUSED_STREAM, or a
connection-level GOAWAY); the relay request then fails with:
http2: Transport: cannot retry err [...] after Request.Body was written;
define Request.GetBody to avoid this error
This affects every relay path that goes through DoApiRequest (chat, claude,
gemini, responses, embedding, image, rerank).
BodyStorage (memory and disk) already implements io.Seeker, so replay support
only needed wiring:
- NewOutboundJSONBody additionally returns a getBody that rewinds the storage
and hands out a fresh non-closing reader. The transport only calls GetBody
after the previous attempt's body has been abandoned, so the rewind cannot
race an in-flight read.
- RelayInfo carries it in the new UpstreamRequestGetBody field, set alongside
UpstreamRequestBodySize by the handlers that build storage-backed bodies.
- applyUpstreamGetBody (symmetric with applyUpstreamContentLength) wires it
into DoApiRequest/DoFormRequest/DoTaskApiRequest, only when req.GetBody is
still nil.
Also remove the hand-rolled GetBody override in DoTaskApiRequest: it returned
the same already-consumed reader, so any transport-level replay would have
silently sent an empty body, and it clobbered the correct snapshot-based
GetBody that net/http derives from the *bytes.Reader bodies the task adaptors
pass in. For non-replayable bodies GetBody now stays nil, so a retry fails
loudly instead of corrupting the request.
Covered by unit tests plus an end-to-end raw-frame HTTP/2 test that resets
the first stream with REFUSED_STREAM after the body is written and asserts
the transport transparently retries with the complete body.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(relay): hand out independent readers from GetBody (address review)
Per the http.Request.GetBody contract ("returns a new copy of Body"),
each call must yield a reader with its own cursor. The previous
implementation rewound and reused the shared BodyStorage, so two
consecutive GetBody readers would interfere with each other, and a
replay could disturb the primary body's offset under extreme transport
timing (e.g. attempt N's body write not yet fully abandoned when the
transport builds attempt N+1).
Instead of snapshotting the payload (an extra copy), add
BodyStorage.NewReader, which returns an independent zero-copy reader:
- memory mode: a fresh bytes.Reader over the same immutable backing
array;
- disk mode: a separate file descriptor over the cache file, so the
transport closing a replayed body only closes that descriptor.
NewOutboundJSONBody's getBody now simply hands out storage.NewReader,
and once the handler releases the storage, GetBody fails with
ErrStorageClosed instead of replaying stale data.
Tests: interleaved reads across two replay readers and the primary
body each observe exactly their own byte stream, for both the memory
and the disk-backed storage; the existing GetBody and HTTP/2 retry
suites still pass (h2 e2e tests flake-free with -count=20).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(relay): bind replayable metadata on pass-through requests
* fix(relay): reset upstream body metadata between channels
* test(relay): cover replay across retries and channel attempts
* fix(relay): stop following upstream redirects
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
44 lines
2.2 KiB
Go
44 lines
2.2 KiB
Go
package common
|
|
|
|
import (
|
|
"io"
|
|
|
|
"github.com/QuantumNous/new-api/common"
|
|
)
|
|
|
|
// NewOutboundJSONBody wraps the already-marshaled upstream request body into a
|
|
// BodyStorage. When disk cache is enabled and the payload exceeds the configured
|
|
// threshold, the data is written to a temp file and the original []byte can be
|
|
// GC'd, significantly reducing the heap residency while waiting for the
|
|
// upstream provider to respond (the dominant cost for large base64 payloads).
|
|
//
|
|
// In memory mode the underlying memoryStorage reuses the same backing array,
|
|
// so this is equivalent to bytes.NewReader(data) in terms of memory usage.
|
|
//
|
|
// The caller MUST invoke closer.Close() once the upstream call has finished
|
|
// (typically via defer) to release the disk file / memory accounting.
|
|
//
|
|
// The returned reader is wrapped with common.ReaderOnly to prevent the HTTP
|
|
// transport from prematurely closing the underlying BodyStorage. The returned
|
|
// size is meant to be propagated to http.Request.ContentLength because the
|
|
// type-erased io.Reader prevents net/http from auto-detecting it.
|
|
//
|
|
// The returned getBody hands out a new, independent reader over the full body
|
|
// on every call, per the http.Request.GetBody contract of returning a fresh
|
|
// copy of the body. It is meant to be propagated to http.Request.GetBody
|
|
// (which net/http likewise cannot derive from a type-erased io.Reader) so the
|
|
// HTTP/2 transport can transparently retry the request when the upstream
|
|
// resets the stream after the body was already written ("http2: Transport:
|
|
// cannot retry err ... after Request.Body was written"). Each reader has its
|
|
// own cursor — in memory mode a fresh bytes.Reader over the shared immutable
|
|
// backing array, in disk mode a separate file descriptor — so replays never
|
|
// share seek state with the primary body or with each other, and closing a
|
|
// replayed reader never releases the underlying storage.
|
|
func NewOutboundJSONBody(data []byte) (body io.Reader, size int64, getBody func() (io.ReadCloser, error), closer io.Closer, err error) {
|
|
storage, err := common.CreateBodyStorage(data)
|
|
if err != nil {
|
|
return nil, 0, nil, nil, err
|
|
}
|
|
return common.ReaderOnly(storage), storage.Size(), storage.NewReader, storage, nil
|
|
}
|