Merge commit from fork

* Harden user setting cache updates

* Fix user update test isolation
This commit is contained in:
Calcium-Ion
2026-07-03 15:25:33 +08:00
committed by GitHub
parent bfddc5fea0
commit dfc0d6324b
6 changed files with 161 additions and 29 deletions
+30 -10
View File
@@ -2,7 +2,6 @@ package model
import (
"database/sql"
"encoding/json"
"errors"
"fmt"
"strconv"
@@ -83,7 +82,7 @@ func (user *User) SetAccessToken(token string) {
func (user *User) GetSetting() dto.UserSetting {
setting := dto.UserSetting{}
if user.Setting != "" {
err := json.Unmarshal([]byte(user.Setting), &setting)
err := common.Unmarshal([]byte(user.Setting), &setting)
if err != nil {
common.SysLog("failed to unmarshal setting: " + err.Error())
}
@@ -92,7 +91,7 @@ func (user *User) GetSetting() dto.UserSetting {
}
func (user *User) SetSetting(setting dto.UserSetting) {
settingBytes, err := json.Marshal(setting)
settingBytes, err := common.Marshal(setting)
if err != nil {
common.SysLog("failed to marshal setting: " + err.Error())
return
@@ -100,6 +99,21 @@ func (user *User) SetSetting(setting dto.UserSetting) {
user.Setting = string(settingBytes)
}
func UpdateUserSetting(userId int, setting dto.UserSetting) error {
if userId == 0 {
return errors.New("id 为空!")
}
settingBytes, err := common.Marshal(setting)
if err != nil {
return err
}
settingValue := string(settingBytes)
if err = DB.Model(&User{}).Where("id = ?", userId).Update("setting", settingValue).Error; err != nil {
return err
}
return updateUserSettingCache(userId, settingValue)
}
// 根据用户角色生成默认的边栏配置
func generateDefaultSidebarConfigForRole(userRole int) string {
defaultConfig := map[string]interface{}{}
@@ -153,7 +167,7 @@ func generateDefaultSidebarConfigForRole(userRole int) string {
// 普通用户不包含admin区域
// 转换为JSON字符串
configBytes, err := json.Marshal(defaultConfig)
configBytes, err := common.Marshal(defaultConfig)
if err != nil {
common.SysLog("生成默认边栏配置失败: " + err.Error())
return ""
@@ -524,11 +538,14 @@ func (user *User) UpdateWithTx(tx *gorm.DB, updatePassword bool) error {
}
}
newUser := *user
tx.First(&user, user.Id)
if err = tx.Model(user).Updates(newUser).Error; err != nil {
current := User{}
if err = tx.First(&current, user.Id).Error; err != nil {
return err
}
return nil
if err = tx.Model(&current).Omit("quota", "used_quota", "request_count").Updates(newUser).Error; err != nil {
return err
}
return tx.First(user, user.Id).Error
}
func (user *User) Edit(updatePassword bool) error {
@@ -558,11 +575,14 @@ func (user *User) EditWithTx(tx *gorm.DB, updatePassword bool) error {
updates["password"] = newUser.Password
}
tx.First(&user, user.Id)
if err = tx.Model(user).Updates(updates).Error; err != nil {
current := User{}
if err = tx.First(&current, user.Id).Error; err != nil {
return err
}
return nil
if err = tx.Model(&current).Updates(updates).Error; err != nil {
return err
}
return tx.First(user, user.Id).Error
}
func (user *User) ClearBinding(bindingType string) error {