feat: enhance text protocol conversion and advanced custom routing (#5825)
* refactor: consolidate relay protocol converters * refactor relayconvert text converters * feat: refine relay converters and advanced custom routing * refactor: enhance logging and add thought signature handling for Gemini requests * refactor: enhance channel cache and pricing endpoint handling for advanced custom models * feat: preserve billing usage semantics * feat: add protocol-aware billing usage * Delete useless files * chore: update action versions in workflow files * chore: update Docker action versions in workflow files * fix: harden billing usage settlement and hot-path route matching - estimate Gemini completion tokens locally when billable usageMetadata is prompt-only but output content was received (e.g. client aborts the stream before the final chunk), and rebuild the attached billing_usage as estimated so settlement does not bill zero output tokens - guard NewClaudeMessagesBillingUsage against all-zero ClaudeUsage, matching the OpenAI/Gemini constructors, so a zero billing_usage cannot override a non-zero top-level usage during settlement - cache compiled advanced-custom route model regexes; they run on the request hot path and were recompiled per request - move the effectiveBillingUsage remap to PostTextConsumeQuota only, and document that calculateTextQuotaSummary expects remapped usage - document the updatePricingLock -> channelSyncLock lock ordering that InitChannelCache/CacheUpdateChannel rely on, and the aux-struct pitfall in GeminiChatResponse.UnmarshalJSON
This commit is contained in:
+30
-9
@@ -25,6 +25,7 @@ var channelSyncLock sync.RWMutex
|
||||
|
||||
func InitChannelCache() {
|
||||
if !common.MemoryCacheEnabled {
|
||||
InvalidatePricingCache()
|
||||
return
|
||||
}
|
||||
newChannelId2channel := make(map[int]*Channel)
|
||||
@@ -94,6 +95,11 @@ func InitChannelCache() {
|
||||
channelsIDM = newChannelId2channel
|
||||
channel2advancedCustomConfig = newChannel2advancedCustomConfig
|
||||
channelSyncLock.Unlock()
|
||||
// Lock ordering: InvalidatePricingCache acquires updatePricingLock, and
|
||||
// GetPricing (holding updatePricingLock) nests channelSyncLock.RLock via
|
||||
// loadPricingAdvancedCustomConfigs. channelSyncLock MUST be released before
|
||||
// invalidating the pricing cache, otherwise the reversed order deadlocks.
|
||||
InvalidatePricingCache()
|
||||
common.SysLog("channels synced from database")
|
||||
}
|
||||
|
||||
@@ -115,12 +121,12 @@ func GetRandomSatisfiedChannel(group string, model string, retry int, requestPat
|
||||
defer channelSyncLock.RUnlock()
|
||||
|
||||
// First, try to find channels with the exact model name.
|
||||
channels := filterChannelsByRequestPath(group2model2channels[group][model], requestPath)
|
||||
channels := filterChannelsByRequestPathAndModel(group2model2channels[group][model], requestPath, model)
|
||||
|
||||
// If no channels found, try to find channels with the normalized model name.
|
||||
if len(channels) == 0 {
|
||||
normalizedModel := ratio_setting.FormatMatchingModelName(model)
|
||||
channels = filterChannelsByRequestPath(group2model2channels[group][normalizedModel], requestPath)
|
||||
channels = filterChannelsByRequestPathAndModel(group2model2channels[group][normalizedModel], requestPath, model)
|
||||
}
|
||||
|
||||
if len(channels) == 0 {
|
||||
@@ -202,12 +208,12 @@ func GetRandomSatisfiedChannel(group string, model string, retry int, requestPat
|
||||
return nil, errors.New("channel not found")
|
||||
}
|
||||
|
||||
// filterChannelsByRequestPath restricts candidates by request path. Only Advanced
|
||||
// Custom (type 58) channels are path-checked: they are kept only when one of their
|
||||
// configured routes matches requestPath. All other channel types always pass.
|
||||
// When requestPath is empty (non-relay callers) filtering is skipped.
|
||||
// filterChannelsByRequestPathAndModel restricts candidates by request path and
|
||||
// model. Only Advanced Custom (type 58) channels are path-checked: they are kept
|
||||
// only when one of their configured routes matches requestPath and model. All
|
||||
// other channel types always pass. When requestPath is empty, filtering is skipped.
|
||||
// Caller must hold channelSyncLock (read lock). The cached slice is never mutated.
|
||||
func filterChannelsByRequestPath(channels []int, requestPath string) []int {
|
||||
func filterChannelsByRequestPathAndModel(channels []int, requestPath string, model string) []int {
|
||||
if requestPath == "" || len(channels) == 0 {
|
||||
return channels
|
||||
}
|
||||
@@ -223,7 +229,7 @@ func filterChannelsByRequestPath(channels []int, requestPath string) []int {
|
||||
filtered = append(filtered, channelId)
|
||||
continue
|
||||
}
|
||||
if config := channel2advancedCustomConfig[channelId]; config != nil && config.SupportsPath(requestPath) {
|
||||
if config := channel2advancedCustomConfig[channelId]; config != nil && config.SupportsPathForModel(requestPath, model) {
|
||||
filtered = append(filtered, channelId)
|
||||
}
|
||||
}
|
||||
@@ -292,8 +298,8 @@ func CacheUpdateChannel(channel *Channel) {
|
||||
return
|
||||
}
|
||||
channelSyncLock.Lock()
|
||||
defer channelSyncLock.Unlock()
|
||||
if channel == nil {
|
||||
channelSyncLock.Unlock()
|
||||
return
|
||||
}
|
||||
|
||||
@@ -304,5 +310,20 @@ func CacheUpdateChannel(channel *Channel) {
|
||||
logger.LogDebug(nil, "CacheUpdateChannel before: id=%d, name=%s, status=%d, polling_index=%d", channel.Id, channel.Name, channel.Status, oldChannel.ChannelInfo.MultiKeyPollingIndex)
|
||||
}
|
||||
channelsIDM[channel.Id] = channel
|
||||
if channel2advancedCustomConfig == nil {
|
||||
channel2advancedCustomConfig = make(map[int]*dto.AdvancedCustomConfig)
|
||||
}
|
||||
delete(channel2advancedCustomConfig, channel.Id)
|
||||
if channel.Type == constant.ChannelTypeAdvancedCustom {
|
||||
if config := channel.GetOtherSettings().AdvancedCustom; config != nil {
|
||||
channel2advancedCustomConfig[channel.Id] = config
|
||||
}
|
||||
}
|
||||
logger.LogDebug(nil, "CacheUpdateChannel after: id=%d, name=%s, status=%d, polling_index=%d", channel.Id, channel.Name, channel.Status, channel.ChannelInfo.MultiKeyPollingIndex)
|
||||
// Lock ordering: do NOT hold channelSyncLock while calling
|
||||
// InvalidatePricingCache. GetPricing acquires updatePricingLock first and then
|
||||
// channelSyncLock.RLock (via loadPricingAdvancedCustomConfigs); acquiring
|
||||
// updatePricingLock while holding channelSyncLock would be an AB-BA deadlock.
|
||||
channelSyncLock.Unlock()
|
||||
InvalidatePricingCache()
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user