fix(topup): guard wallet quota during recharge

controller/topup_quota_limit_test.go

@@ -7,11 +7,14 @@ import (
 	"testing"
 
 	"github.com/QuantumNous/new-api/common"
+	"github.com/QuantumNous/new-api/model"
 	"github.com/QuantumNous/new-api/setting/operation_setting"
 	"github.com/gin-gonic/gin"
+	"github.com/glebarez/sqlite"
 	"github.com/shopspring/decimal"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+	"gorm.io/gorm"
 )
 
 func TestTopUpQuotaValidation(t *testing.T) {
@@ -84,8 +87,9 @@ func TestValidateTopUpQuotaReturnsMaximumAmount(t *testing.T) {
 		Div(decimal.NewFromFloat(common.QuotaPerUnit)).
 		Floor().IntPart()
 
-	require.NoError(t, validateTopUpQuota(maxAmount))
-	err := validateTopUpQuota(maxAmount + 1)
+	_, err := validateTopUpQuota(maxAmount)
+	require.NoError(t, err)
+	_, err = validateTopUpQuota(maxAmount + 1)
 	require.EqualError(t, err, "单笔充值数量不能大于 4294")
 }
 
@@ -115,12 +119,60 @@ func TestRequestAmountRejectsTopUpThatCannotBeSettled(t *testing.T) {
 	assert.JSONEq(t, `{"message":"error","data":"单笔充值数量不能大于 4294"}`, recorder.Body.String())
 }
 
+func TestRequestAmountRejectsTopUpThatWouldOverflowWallet(t *testing.T) {
+	oldQuotaPerUnit := common.QuotaPerUnit
+	oldDisplayType := operation_setting.GetGeneralSetting().QuotaDisplayType
+	oldDB := model.DB
+	common.QuotaPerUnit = 500000
+	operation_setting.GetGeneralSetting().QuotaDisplayType = operation_setting.QuotaDisplayTypeUSD
+
+	db, err := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{})
+	require.NoError(t, err)
+	require.NoError(t, db.AutoMigrate(&model.User{}))
+	model.DB = db
+	t.Cleanup(func() {
+		common.QuotaPerUnit = oldQuotaPerUnit
+		operation_setting.GetGeneralSetting().QuotaDisplayType = oldDisplayType
+		model.DB = oldDB
+		sqlDB, dbErr := db.DB()
+		if dbErr == nil {
+			require.NoError(t, sqlDB.Close())
+		}
+	})
+
+	require.NoError(t, model.DB.Create(&model.User{
+		Id:       42,
+		Username: "topup_capacity_user",
+		Quota:    1_000_000,
+		Status:   common.UserStatusEnabled,
+	}).Error)
+
+	gin.SetMode(gin.TestMode)
+	recorder := httptest.NewRecorder()
+	ctx, _ := gin.CreateTestContext(recorder)
+	ctx.Set("id", 42)
+	ctx.Request = httptest.NewRequest(
+		http.MethodPost,
+		"/api/user/amount",
+		strings.NewReader(`{"amount":4294}`),
+	)
+	ctx.Request.Header.Set("Content-Type", "application/json")
+
+	RequestAmount(ctx)
+
+	assert.Equal(t, http.StatusOK, recorder.Code)
+	assert.JSONEq(t, `{"message":"error","data":"top-up quota limit exceeded"}`, recorder.Body.String())
+}
+
 func TestValidateCreditedQuotaRejectsOverflow(t *testing.T) {
-	require.NoError(t, validateCreditedQuota(decimal.NewFromInt(common.MaxQuota-1)))
-	require.EqualError(t, validateCreditedQuota(decimal.Zero), "充值额度必须大于 0")
+	_, err := validateCreditedQuota(decimal.NewFromInt(common.MaxQuota - 1))
+	require.NoError(t, err)
+	_, err = validateCreditedQuota(decimal.Zero)
+	require.EqualError(t, err, "充值额度必须大于 0")
+	_, err = validateCreditedQuota(decimal.NewFromInt(common.MaxQuota))
 	require.EqualError(
 		t,
-		validateCreditedQuota(decimal.NewFromInt(common.MaxQuota)),
+		err,
 		"充值额度超出系统可表示范围",
 	)
 }
@@ -135,8 +187,10 @@ func TestStripeCreditedQuotaIncludesGroupRatio(t *testing.T) {
 		require.NoError(t, common.UpdateTopupGroupRatioByJSONString(oldTopupGroupRatio))
 	})
 
-	require.NoError(t, validateCreditedQuota(getStripeCreditedQuota(2147, "vip")))
-	require.Error(t, validateCreditedQuota(getStripeCreditedQuota(2148, "vip")))
+	_, err := validateCreditedQuota(getStripeCreditedQuota(2147, "vip"))
+	require.NoError(t, err)
+	_, err = validateCreditedQuota(getStripeCreditedQuota(2148, "vip"))
+	require.Error(t, err)
 
 	require.NoError(t, common.UpdateTopupGroupRatioByJSONString(`{"free":0}`))
 	assert.True(t, decimal.NewFromInt(500000).Equal(getStripeCreditedQuota(1, "free")))