♻️ refactor(web): consolidate design-system primitives and responsive data views

web/default/src/features/dashboard/lib/flow-selection.test.ts

@@ -1,56 +1,13 @@
 import assert from 'node:assert/strict'
 import { describe, test } from 'node:test'
 
-import type { FlowUserFilterOption } from '../types'
 import {
   compactFlowSelectionLabel,
   flowDisplayState,
   requireSuccessfulFlowRows,
-  visibleFlowUsers,
 } from './flow-selection'
 
-const users: FlowUserFilterOption[] = [
-  {
-    value: 'user:1',
-    label: 'dry',
-    valueLabel: '100',
-    valueRaw: 100,
-    color: '#1664ff',
-  },
-  {
-    value: 'user:2',
-    label: 'jrc',
-    valueLabel: '70',
-    valueRaw: 70,
-    color: '#1ac6ff',
-  },
-]
-
 describe('dashboard flow selection helpers', () => {
-  test('limits user chips to currently visible users', () => {
-    assert.deepEqual(
-      visibleFlowUsers(users, []).map((user) => user.value),
-      ['user:1', 'user:2']
-    )
-    assert.deepEqual(
-      visibleFlowUsers(users, ['user:2']).map((user) => user.value),
-      ['user:2']
-    )
-  })
-
-  test('filters visible users without mutating the source options', () => {
-    const visible = visibleFlowUsers(users, ['user:1'])
-
-    assert.deepEqual(
-      visible.map((user) => user.value),
-      ['user:1']
-    )
-    assert.deepEqual(
-      users.map((user) => user.value),
-      ['user:1', 'user:2']
-    )
-  })
-
   test('formats compact selected counts for flow multiselect summaries', () => {
     assert.equal(compactFlowSelectionLabel(0), '*')
     assert.equal(compactFlowSelectionLabel(1), '1')

web/default/src/features/dashboard/lib/flow-selection.ts

@@ -16,10 +16,7 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
 
 For commercial licensing, please contact support@quantumnous.com
 */
-import type {
-  FlowQuotaDataItem,
-  FlowUserFilterOption,
-} from '@/features/dashboard/types'
+import type { FlowQuotaDataItem } from '@/features/dashboard/types'
 
 export type FlowDisplayState = 'loading' | 'error' | 'empty' | 'chart'
 
@@ -55,12 +52,3 @@ export function flowDisplayState(options: {
 export function compactFlowSelectionLabel(count: number): string {
   return count > 0 ? String(count) : '*'
 }
-
-export function visibleFlowUsers(
-  users: FlowUserFilterOption[],
-  selectedUsers: string[]
-): FlowUserFilterOption[] {
-  if (selectedUsers.length === 0) return users
-  const selected = new Set(selectedUsers)
-  return users.filter((user) => selected.has(user.value))
-}

web/default/src/features/dashboard/lib/flow.test.ts

@@ -2,11 +2,7 @@ import assert from 'node:assert/strict'
 import { describe, test } from 'node:test'
 
 import type { FlowQuotaDataItem } from '../types'
-import {
-  buildDashboardFlowData,
-  buildFlowFilterOptions,
-  buildFlowSankeySpec,
-} from './flow'
+import { buildDashboardFlowData, buildFlowSankeySpec } from './flow'
 
 const rows: FlowQuotaDataItem[] = [
   {
@@ -276,7 +272,9 @@ describe('dashboard flow data', () => {
   })
 
   test('builds user filter options with stable values', () => {
-    const options = buildFlowFilterOptions(rows, 'quota')
+    const options = buildDashboardFlowData(rows, 'quota', {
+      role: 'admin',
+    }).filterOptions
 
     assert.deepEqual(
       options.users.map((user) => [user.value, user.label, user.valueLabel]),

web/default/src/features/dashboard/lib/flow.ts

@@ -947,28 +947,6 @@ function buildNodeFilterOptions(
   )
 }
 
-export function buildFlowFilterOptions(
-  rows: FlowQuotaDataItem[],
-  metric: FlowMetric = 'quota',
-  palette?: readonly string[],
-  role: FlowRole = DEFAULT_FLOW_ROLE,
-  visibleStages?: FlowNodeKind[],
-  selectedNodes?: readonly FlowNodeFilter[]
-): FlowFilterOptions {
-  return {
-    users: buildUserFilterOptions(rows, metric, palette),
-    nodes: buildNodeFilterOptions(
-      rows,
-      metric,
-      role,
-      visibleStages,
-      palette,
-      EMPTY_FLOW_PATH_CONTEXT,
-      selectedNodes
-    ),
-  }
-}
-
 export function buildDashboardFlowData(
   rows: FlowQuotaDataItem[],
   metric: FlowMetric = 'quota',